[PATCH 03/12] iommu/amd: Don't disable IRQs in __detach_device

From: Joerg Roedel
Date: Tue Oct 20 2015 - 11:36:38 EST


From: Joerg Roedel <jroedel@xxxxxxx>

This function is already called with IRQs disabled already.
So no need to disable them again.

Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
---
drivers/iommu/amd_iommu.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index b86c5f0..54e0862 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2198,18 +2198,17 @@ static int attach_device(struct device *dev,
static void __detach_device(struct iommu_dev_data *dev_data)
{
struct protection_domain *domain;
- unsigned long flags;

if (WARN_ON(!dev_data->domain))
return;

domain = dev_data->domain;

- spin_lock_irqsave(&domain->lock, flags);
+ spin_lock(&domain->lock);

do_detach(dev_data);

- spin_unlock_irqrestore(&domain->lock, flags);
+ spin_unlock(&domain->lock);
}

/*
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/