Re: [PATCH 4/4] perf evsel: Print branch filter state with -vv

From: Ingo Molnar
Date: Wed Oct 21 2015 - 05:25:39 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Tue, Oct 20, 2015 at 05:25:07PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> >
> > Add a missing field to the perf_event_attr debug output.
> >
> > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Link: http://lkml.kernel.org/r/1445366797-30894-4-git-send-email-andi@xxxxxxxxxxxxxx
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > ---
> > tools/perf/util/evsel.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index 8be867ccefe9..11bf3f2c51cd 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -1229,6 +1229,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> > PRINT_ATTRf(config, p_hex);
> > PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned);
> > PRINT_ATTRf(sample_type, p_sample_type);
> > + PRINT_ATTRf(branch_sample_type, p_unsigned);
> > PRINT_ATTRf(read_format, p_read_format);
>
> As said in the original thread, this is the wrong place, it should be
> between config2 and sample_regs_user.

Ok, I've unpulled these updates, since I haven't pushed these bits out yet.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/