Re: [PATCH 0/3] ARM: dts: Enable Exynos RNG module
From: Tobias Jakobi
Date: Sat Oct 24 2015 - 19:59:00 EST
Krzysztof Kozlowski wrote:
> On 20.10.2015 01:11, Tobias Jakobi wrote:
>> Hello Krzysztof,
>> I can confirm that this also works on a Odroid-X2, so I guess it's safe
>> to enable the PRNG for all Exynos4412-based Odroid devices.
> Sure, I can send a patch for that. I can test it later also on Odroid-U3.
>> Any chance that you might also take a look at the other hwcrypto stuff
>> on the SoC ('samsung,exynos4210-secss' compatible)?
> What do you mean? The s5p-sss driver already supports Device Tree.
The driver supports DT, but it doesn't really work.
I'm using the following DT entry to let the driver probe correctly:
But the crypto self-test fails on boot:
alg: skcipher: encryption failed on test 1 for ecb-aes-s5p: ret=22
Another problems is that SSS and PRNG can't be used at the same time,
since they both use common hardware resources (I think it was IO).
With best wishes,
> Best regards,
>> With best wishes,
>> Krzysztof Kozlowski wrote:
>>> The patchset adds necessary clock from Security SubSystem (SSS)
>>> and enables the PRNG module of Exynos for Trats2 board.
>>> The first patch (clock) is required for other ones so please
>>> take everything in one step.
>>> The actual Device Tree support (and compatible) was sent in separate
>>> - https://patchwork.kernel.org/patch/7432891/
>>> - http://marc.info/?l=linux-crypto-vger&m=144522952725052&w=2
>>> The device can be tested (after applying both patchsets) with:
>>> $ echo exynos > /sys/class/misc/hw_random/rng_current
>>> $ dd if=/dev/hwrng of=/dev/null bs=1 count=16
>>> Best regards,
>>> Krzysztof Kozlowski (3):
>>> clk: samsung: exynos4: Add SSS gate clock
>>> ARM: dts: Add PRNG module for exynos4
>>> ARM: dts: Enable PRNG module on exynos4412-trats2
>>> arch/arm/boot/dts/exynos4.dtsi | 8 ++++++++
>>> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++++
>>> drivers/clk/samsung/clk-exynos4.c | 1 +
>>> include/dt-bindings/clock/exynos4.h | 1 +
>>> 4 files changed, 14 insertions(+)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/