Re: [PATCH 10/13] lib/test_printf.c: account for kvasprintf tests

From: Kees Cook
Date: Mon Oct 26 2015 - 02:44:06 EST


On Wed, Oct 21, 2015 at 5:30 AM, Rasmus Villemoes
<linux@xxxxxxxxxxxxxxxxxx> wrote:
> These should also count as performed tests.
>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

> ---
> lib/test_printf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 80ddafb2675d..8fca007d9bcd 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -127,6 +127,7 @@ __test(const char *expect, int elen, const char *fmt, ...)
>
> p = kvasprintf(GFP_KERNEL, fmt, ap);
> if (p) {
> + total_tests++;
> if (memcmp(p, expect, elen+1)) {
> pr_warn("kvasprintf(..., \"%s\", ...) returned '%s', expected '%s'\n",
> fmt, p, expect);
> --
> 2.6.1
>



--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/