Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

From: Toshi Kani
Date: Mon Oct 26 2015 - 12:55:05 EST

On Mon, 2015-10-26 at 16:46 +0000, Luck, Tony wrote:
> > + ((param2 & PAGE_MASK) != PAGE_MASK))
> > return -EINVAL;
> >
> > The 3rd condition check makes sure that the param2 mask is the page size or less. So,
> > I think we are OK on this.
> Oops. The original was even on the screen as part of the diff (which I signed off on
> just two years ago).
> I'd be happier if you made it the 1st condition though, so we skip calling
> region_intersects_*() with a nonsense "size" argument.

Agreed. I will send an updated patch 3/3 later today, "[PATCH v2 UPDATE-2 3/3]".


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at