Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature

[Aravind Gopalakrishnan]

On 10/26/2015 3:22 PM, Borislav Petkov wrote:
> On Mon, Oct 26, 2015 at 10:12:59AM -0500, Aravind Gopalakrishnan wrote:
> > For large part yes, wrapped code in patch form with commit message etc.
> > And modified comment a little bit.
> >
> > Does that still require his address in "From"?
> Yes, because it sounds like he was the author of the original patch.

Okay, will fix that in V2.

> No, I think you should add that bit to init_scattered_cpuid_features()
> instead.
>
> And btw, those Intel QoS single bit defines and the XSAVE stuff there
> should move to that function too - that's a pure waste having them in
> the cap_flags array. I'll fix that.

Ok, I added it to init_scattered_cpuid_features() on top of your RFC 
patch and it seems to work fine.

How do you prefer a V2 for this to be sent though-
Shall I wait until your fixes are in tip.git and resend?
Or send a V2 on top of current tip.git?

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/