Re: [PATCH 1/2] hwmon: ina2xx: convert driver to using regmap

From: Guenter Roeck
Date: Mon Oct 26 2015 - 21:12:34 EST


On Mon, Oct 26, 2015 at 05:24:32PM +0100, Marc Titinger wrote:
> Any sysfs "show" read access from the client app will result in reading
> all registers (8 with ina226). Depending on the host this can limit the
> best achievable read rate.
>
> This changeset allows for individual register accesses through regmap.
>
> Tested with BeagleBone Black (Baylibre-ACME) and ina226.
>
> Signed-off-by: Marc Titinger <mtitinger@xxxxxxxxxxxx>

Another comment: In ina2xx_calibrate, also use regmap_write().
Then you can drop the client variable in ina2xx_data.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/