Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator

From: Mark Brown
Date: Mon Oct 26 2015 - 22:13:09 EST


On Mon, Oct 26, 2015 at 12:25:17PM +0100, Heiko Schocher wrote:
> add DT support for the tps6502x regulators.

Please use subject lines matching the style for the subsystem.

> + regulators = of_get_child_by_name(np, "regulators");
> + if (!regulators) {
> + dev_err(dev, "regulator node not found\n");
> + return NULL;
> + }

Please use the generic support for locating the DT information for
regulators using regulators_node and of_match in the regulator_desc
rather than open coding this.

Attachment: signature.asc
Description: PGP signature