Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

From: Bart Van Assche
Date: Mon Oct 26 2015 - 22:29:35 EST

On 10/26/15 07:54, Peter Oberparleiter wrote:
Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
returns the value of that number instead of the number of bytes written.
This behavior can confuse programs expecting POSIX write() semantics.
Fix this by returning the number of bytes written instead.

Signed-off-by: Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
drivers/scsi/scsi_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index b333389..6b0f292 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
return -EINVAL;

sdev->queue_ramp_up_period = msecs_to_jiffies(period);
- return period;
+ return count;

static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,

Hello Peter,

Good catch. But please CC the people who introduced this code and also "stable" (see also commit 4a84067dbfce436b81779e585bf712b02ceee552).


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at