Re: [PATCH 01/10] pwm: lpc18xx_pwm: use pwm_set_chip_data
From: Olliver Schinagl
Date: Tue Oct 27 2015 - 03:22:40 EST
On October 26, 2015 10:58:18 PM CET, Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote:
>Not sure why there's some many people in Cc for such a silly change.
>I guess you are using get_maintainers.pl on the entire patchset and get
>this rather long list.
I did indeed use the script and for v2 i'll split it up in several patches. The grouping that made sense to me was it was all pwm related. I'll do better next time. Sorry.
>IMO, the value of submitting patches as part of a larger series is to
>be able to
>push patches that need to be applied in some given order, or otherwise
>have some kind of logical relationship between them.
>However, this is not the case: it's just a very small change and has
>no relation to the rest of the patches in the series.
>I think a simple standalone patch would be better here.
>Also, get_maintainer.pl is just a hint, and not meant to be used as-is.
>In particular, you are missing the driver's author.
>On 26 October 2015 at 18:32, Olliver Schinagl
>> From: Olliver Schinagl <oliver@xxxxxxxxxxx>
>> The lpc18xx driver currently manipulates the pwm_device struct
>> rather then using the pwm_set_chip_data. While the current method may
>> save a clock cycle or two, it is more obvious that data is set to the
>> chip pointer (especially since it is only a single int holding
>> Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
>> drivers/pwm/pwm-lpc18xx-sct.c | 11 +++++++----
>> drivers/pwm/pwm-sun4i.c | 11 +++++++++++
>> 2 files changed, 18 insertions(+), 4 deletions(-)
>...and this diffstat is obviously fishy.
It does.indeed, somehow i.must have accidentally merged two patches, stupid me. This.will also be addressed in the v2.
Sent from my Android device with K-9 Mail. Please excuse my brevity.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/