Re: [PATCH 2/5] mtd: nand: drop unnecessary partition parser data

From: Boris Brezillon
Date: Tue Oct 27 2015 - 03:53:01 EST

On Mon, 26 Oct 2015 19:31:07 -0700
Brian Norris <computersforpeace@xxxxxxxxx> wrote:

> All of these drivers set up a parser data struct just to communicate DT
> partition data. This field has been deprecated and is instead supported
> by telling nand_scan_ident() about the 'flash_node'.
> This patch:
> * sets chip->flash_node for those drivers that didn't already (but used
> OF partitioning)

As mentioned in patch 1, I think we should get rid of the ->flash_node
field and directly set mtd->dev.of_node instead. If we want to hide
MTD internals we could provide this kind of helper:

static inline void mtd_set_of_node(struct mtd_device *mtd,
struct device_node *np)
mtd->dev.of_node = np;

> * drops the parser data
> * switches to the simpler mtd_device_register() where possible, now
> that we've eliminated one of the auxiliary parameters
> Now that we've assigned chip->flash_node for these drivers, we can
> probably rely on nand_dt_init() to do more of the DT parsing for us, but
> for now, I don't want to fiddle with each of these drivers. The parsing
> is done in duplicate for now on some drivers. I don't think this should
> break things. (Famous last words.)
> Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx>

For the sunxi_nand driver

Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>



Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at