Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path

From: Dan Carpenter
Date: Tue Oct 27 2015 - 06:04:47 EST

On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote:
> -error_cleanup_open:
> +dprc_scan_container_error:
> (void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);

The error label was better in the original code. A "goto
error_cleanup_open", that tells you what the goto does. "goto
dprc_scan_container_error" tells you nothing because you can see from
the line before that there was a container error. No new information.
It's just like a function name tells you what a function does. You
wouldn't name the function called_from_main().

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at