Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

From: Mark Rutland
Date: Tue Oct 27 2015 - 11:03:59 EST

> >>>>+ - ctrl-reg : offset to the following SAS control registers (in order):
> >>>>+ - reset assert
> >>>>+ - clock disable
> >>>>+ - reset status
> >>>>+ - reset de-assert
> >>>>+ - clock enable


> >It would be better to have each offset in a separate property.
> >
> These register are not used for different purpose.
> Instead, they are all used for one purpose, reset the sas controller;
> Though a bit complicated, the silicon has special requirement here.

While they are indeed used together, they are separate registers, as
listed above. There may be other registers in future that turn out to
be useful for the SAS controller, or it might turn out a new system
doesn't have all of the existing registers.

> So still prefer using the original method,
> ctrl-reg = <0xa60 0x33c 0x5a30 0xa64 0x338>;
> Since we can simply use of_property_read_u32_array.

That may be simpler now, but makes future maintenance harder.

Use separate properties.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at