[PATCH 18/70] cpufreq: interactive: keep freezer happy when not current governor

From: BÃlint Czobor
Date: Tue Oct 27 2015 - 13:59:09 EST

From: Sam Leffler <sleffler@xxxxxxxxxxxx>

Fix a problem where the hung task mechanism was deeming the interactive
clock boost thread as hung. This was because the thread is created at
module init but never run/woken up until needed. If the governor is not
being used this can be forever. To workaround this explicitly wake up
the thread once all the necessary data structures are initialized. The
latter required some minor code shuffle.

Signed-off-by: Sam Leffler <sleffler@xxxxxxxxxxxx>
Change-Id: Ie2c058dd75dcb6460ea10e7ac997e46baf66b1fe
Signed-off-by: BÃlint Czobor <czoborbalint@xxxxxxxxx>
drivers/cpufreq/cpufreq_interactive.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/cpufreq/cpufreq_interactive.c b/drivers/cpufreq/cpufreq_interactive.c
index 2038991..184140a 100644
--- a/drivers/cpufreq/cpufreq_interactive.c
+++ b/drivers/cpufreq/cpufreq_interactive.c
@@ -953,6 +953,10 @@ static int __init cpufreq_interactive_init(void)
pcpu->cpu_timer.data = i;

+ spin_lock_init(&up_cpumask_lock);
+ spin_lock_init(&down_cpumask_lock);
+ mutex_init(&set_speed_lock);
up_task = kthread_create(cpufreq_interactive_up_task, NULL,
if (IS_ERR(up_task))
@@ -968,14 +972,12 @@ static int __init cpufreq_interactive_init(void)
if (!down_wq)
goto err_freeuptask;

- INIT_WORK(&freq_scale_down_work,
- cpufreq_interactive_freq_down);
+ INIT_WORK(&freq_scale_down_work, cpufreq_interactive_freq_down);
+ INIT_WORK(&inputopen.inputopen_work, cpufreq_interactive_input_open);

- spin_lock_init(&up_cpumask_lock);
- spin_lock_init(&down_cpumask_lock);
- mutex_init(&set_speed_lock);
+ /* NB: wake up so the thread does not look hung to the freezer */
+ wake_up_process(up_task);

- INIT_WORK(&inputopen.inputopen_work, cpufreq_interactive_input_open);
return cpufreq_register_governor(&cpufreq_gov_interactive);


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/