Re: [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes

From: Peter Hurley
Date: Tue Oct 27 2015 - 14:09:12 EST


On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 198 bytes of machine code.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> CC: Jiri Slaby <jslaby@xxxxxxxx>
> CC: linux-serial@xxxxxxxxxxxxxxx
> ---
> drivers/tty/n_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index b09023b..c38f5d8 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -1407,7 +1407,7 @@ handle_newline:
> return 0;
> }
>
> -static inline void
> +static void
> n_tty_receive_char_inline(struct tty_struct *tty, unsigned char c)
> {
> struct n_tty_data *ldata = tty->disc_data;
>

This is one of the patches I will rework differently to remove the
inlining (n_tty_receive_char_inline() can be deleted and its call
sites replaced with n_tty_receive_char()).

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/