Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls

From: Maxime Ripard
Date: Tue Oct 27 2015 - 14:27:14 EST


On Sat, Oct 24, 2015 at 01:11:52PM +0100, Adam Sampson wrote:
> The power amplifier for the headphone output is called "the PA" and "the
> headphone amplifier" in Allwinner's documentation for the A10 and A20.
> sun4i-codec calls it "PA" in some places and "Pre-Amplifier" (which
> isn't really accurate) in others, leading to user-visible controls with
> different names referring to the same device.
> When this driver implements audio input, it'll also need to expose
> controls for the line and mic input preamps, so just referring to "the
> Pre-Amplifier" will be ambiguous.
> Change it to use "PA" consistently for the power amplifier.

Just to avoid any ambiguity in the future, could you call that Power
Amp(lifier?) instead?


Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering

Attachment: signature.asc
Description: Digital signature