Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

From: Alim Akhtar
Date: Wed Oct 28 2015 - 06:40:38 EST

Hi Alexandre,

On 10/28/2015 03:18 PM, Alexandre Belloni wrote:
On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote :
The s2mps13 clock driver added new name and compatible... which was
probably totally unneeded (I missed that during review). We don't have
to make this as a rule...

Since we do not have any data about future workarounds and the
differences then just follow Ockham's razor - use the same name and

So you don't care about DT backward compatibility because when a
workaround will be needed for one of the IPs, then you will have to
update the old dtb to use it.

Unless you are sure that the IP is the same, doing

{ "s2mps15-rtc", S2MPS14X },

is probably the best way to handle that. Note that I personally don't
care about the DT ABI, I'm just pointing out what may happen ;)

Thats what my point is, anyway I am still looking into the fine prints of the s2mps15 and s2mps14 user manual, now I have found at least one difference in their one of the register bit, which might be a good reason to keep s2mps15-rtc device.
Will update the same in v4.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at