Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler
From: Javier Martinez Canillas
Date: Wed Oct 28 2015 - 07:02:57 EST
On 10/27/2015 11:10 AM, Ulf Hansson wrote:
> On 21 October 2015 at 17:15, Javier Martinez Canillas
> <javier@xxxxxxxxxxxxxxx> wrote:
>> The pwrseq_emmc driver does a eMMC card reset before a system reboot to
>> allow broken or limited ROM boot-loaders (that don't have an eMMC reset
>> logic) to be able to read the second stage from the eMMC.
>> But this has to be called before a system reboot handler and while most
>> of them use the priority 128, there are other restart handlers (such as
>> the syscon-reboot one) that use a higher priority. So, use the highest
>> priority to make sure that the eMMC hw is reset before a system reboot.
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> Tested-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
>> Tested-by: Anand Moon <linux.amoon@xxxxxxxxx>
>> Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>> This patch was needed since a recent series from Alim  added
>> syscon reboot and poweroff support to Exynos SoCs and removed
>> the reset handler in the Exynos Power Management Unit (PMU) code.
>> But the PMU and syscon-reboot restart handler have a different
>> priority so  breaks restart when eMMC is used on these boards.
>> : http://www.spinics.net/lists/arm-kernel/msg454396.html
>> So this patch must be merged before  to avoid regressions.
>> Best regards,
> So it seems like there have been a good discussion around this. I
> don't have any objections, but is more concerned about potential
Yes, there was a lot of discussion indeed but it seems we all agree
on the approach and that the patch should not land before having a
lot of testing.
> I have queued it up for next (4.4) so we get some testing in
> linux-next. If anyone have issues, please report them.
great, some weeks sitting in -next to let the CI infrastructure to
play with it seems reasonable to me. Thanks a lot!
> Kind regards
Javier Martinez Canillas
Open Source Group
Samsung Research America
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/