Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

From: Krzysztof Kozlowski
Date: Wed Oct 28 2015 - 09:13:53 EST

W dniu 28.10.2015 o 18:55, Lee Jones pisze:
> On Wed, 28 Oct 2015, Uwe Kleine-KÃnig wrote:
>> Hello,
>> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote:
>>> On 28.10.2015 17:24, Lee Jones wrote:
>>>> You guys are pushing back like this is some kind of demotion.
>>>> That's not the case at all. All it does is better describe the (very
>>>> worthy) function you *actually* provide.
>>> It is getting into dispute about entire change of yours... which is not
>>> what I want. I agree with your general idea but I was referring only to
>>> that particular case - the Samsung PMICs (and Maxim PMICs/MUICs which
>>> would fall into same category).
>> Not being affected by this change, I wonder what the technical
>> difference is if someone is listed as reviewer instead of maintainer.
>> Does behave differently?
> Reviewers are people who should be Cc'ed on all patches, as are
> Maintainers, so no, fundamentally they are treated the same by a
> Submitter.
> Here is some output for Maintainers/Reviews from
> $ ./scripts/ -f arch/arm/boot/dts/vf500.dtsi
> Shawn Guo <shawnguo@xxxxxxxxxx> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
> Sascha Hauer <kernel@xxxxxxxxxxxxxx> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
> Stefan Agner <stefan@xxxxxxxx> (reviewer)
> Russell King <linux@xxxxxxxxxxxxxxxx> (maintainer:ARM PORT)
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
> devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
> I'm sure we can make the output even more similar by listing the
> MAINTAINERS tag after "reviewer" too.

And here is the output of drivers/mfd/sec-core.c *before*:
Sangbeom Kim <sbkim73@xxxxxxxxxxx> (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS)
Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS)
Lee Jones <lee.jones@xxxxxxxxxx> (supporter:MULTIFUNCTION DEVICES (MFD))

and after (where I am listed as reviewer):
Sangbeom Kim <sbkim73@xxxxxxxxxxx> (reviewer)
Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> (reviewer)
Lee Jones <lee.jones@xxxxxxxxxx> (supporter:MULTIFUNCTION DEVICES (MFD))

Maybe it should be "supporter reviewer"?

Best regards,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at