Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis

From: Joe Perches
Date: Wed Oct 28 2015 - 14:23:59 EST

On Wed, 2015-10-28 at 19:13 +0100, Bogicevic Sasa wrote:
> This fixes all Alignment should match open parenthesis
> messages from

What you suggest is not at all generally accepted kernel style.

> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
> return -ENOMEM;
> skb_reserve(skb_out, NET_IP_ALIGN);
> - memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
> + memcpy(
> + skb_put(skb_out, mac_header_len), mac_header_data,
> mac_header_len);

What's desired here is:

memcpy(skb_put(skb_out, mac_header_len), mac_header_data,

Second line should be:
[tab][7 spaces]mac_header_len);


btw: Please run your _patches_ through, not just
use it to find style issues in files.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at