Re: [PATCH v2 1/5] pmem, dax: clean up clear_pmem()

From: Jeff Moyer
Date: Wed Oct 28 2015 - 17:01:37 EST

Dan Williams <dan.j.williams@xxxxxxxxx> writes:

> On Thu, Oct 22, 2015 at 1:48 PM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
>> Dan Williams <dan.j.williams@xxxxxxxxx> writes:
>>> Both, __dax_pmd_fault, and clear_pmem() were taking special steps to
>>> clear memory a page at a time to take advantage of non-temporal
>>> clear_page() implementations. However, x86_64 does not use
>>> non-temporal instructions for clear_page(), and arch_clear_pmem() was
>>> always incurring the cost of __arch_wb_cache_pmem().
>>> Clean up the assumption that doing clear_pmem() a page at a time is more
>>> performant.
>> Wouldn't another solution be to actually use non-temporal stores?
> Sure.
>> Why did you choose to punt?
> Just a priority call at this point. Patches welcome of course ;-).

OK. Patch is harmless.

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at