Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs

[Lu, Baolu]

On 10/28/2015 08:40 PM, Greg Kroah-Hartman wrote:
> > >+struct debug_buffer {
> > >+	ssize_t (*fill_func)(struct debug_buffer *);
> > >+	struct usb_bus *bus;
> > >+	struct mutex mutex;
> > >+	size_t count;
> > >+	char *output_buf;
> > >+	size_t alloc_size;
> > >+};
> > >+
> > >+static const char *get_extcap_desc(u32 cap_id)
> > >+{
> > >+	switch (cap_id) {
> > >+	case XHCI_EXT_CAPS_LEGACY:
> > >+		return "USB Legacy Support";
> > >+	case XHCI_EXT_CAPS_PROTOCOL:
> > >+		return "Supported Protocol";
> > >+	case XHCI_EXT_CAPS_PM:
> > >+		return "Extended Power Management";
> > >+	case XHCI_EXT_CAPS_VIRT:
> > >+		return "I/O Virtualization (xHCI-IOV)";
> > >+	case XHCI_EXT_CAPS_ROUTE:
> > >+		return "Message Interrupt";
> > >+	case XHCI_EXT_CAPS_LOCALMEM:
> > >+		return "Local Memory";
> > >+	case XHCI_EXT_CAPS_DEBUG:
> > >+		return "USB Debug Capability";
> This is a lot more stuff than just debug port, it should be in sysfs
> as individual files, not one big one that you somehow have to parse in
> order to determine this information.

I will move it into sysfs in v2.

Thanks,
Baolu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/