Re: [PATCH v2] pwm-backlight: fix the panel power sequence
From: Philipp Zabel
Date: Thu Oct 29 2015 - 11:41:14 EST
Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang:
> In the case of the panel disabled by the bootloader,
> your patch still has the following code and always enables the backlight
> in the probe function.
> pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
> - GPIOD_OUT_HIGH);
You are right.
> What do you think if I remove these two lines in my patch?
> if (pb->enable_gpio)
> gpiod_direction_output(pb->enable_gpio, 0);
That won't work if the gpio is still configured as input. How about I
add the GPIOD_ASIS change to my patch you remove that and the above from
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/