Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code

[Tim Chen]

On Thu, 2015-10-29 at 03:03 +0100, Stephan Mueller wrote:
> Am Mittwoch, 28. Oktober 2015, 14:19:29 schrieb Tim Chen:
> 
> Hi Tim,
> 
> >+
> >+	/* check for dependent cpu features */
> >+	if (!cpu_has_aes) {
> >+		pr_err("aes_cbc_mb_mod_init: no aes support\n");
> >+		err = -ENODEV;
> >+		goto err1;
> >+	}
> 
> In your post 0/5, you say that this mechanism needs AVX2. In the existing 
> AESNI glue code I find
> 
> #ifdef CONFIG_X86_64
> #ifdef CONFIG_AS_AVX2
>         if (boot_cpu_has(X86_FEATURE_AVX2)) {
> 
> ...
> 
> Why would that CPU check not be needed here?

Good catch.  Will add check for avx2.

Tim

> 
> Ciao
> Stephan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/