Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default
From: Masahiro Yamada
Date: Thu Oct 29 2015 - 22:02:15 EST
2015-10-29 22:33 GMT+09:00 Linus Walleij <linus.walleij@xxxxxxxxxx>:
> On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> Add "default y" to the Kconfig rather than adding entries into
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>> config PINCTRL_UNIPHIER_PH1_LD4
>> tristate "UniPhier PH1-LD4 SoC pinctrl driver"
>> + default y
>> select PINCTRL_UNIPHIER_CORE
> Why is it not default y if <PH1_LD4_SOC_THING>?
> So it is only turned on if the corresponding SoC is selected?
> Or don't you have symbols like that?
No, I don't have such per-SoC symbols.
I only have ARCH_UNIPHIER, for the whole UniPhier SoC family.
We no longer #ifdef <SOC_THING> in C sources.
The only difference among SoCs is, which drivers should be enabled.
All SoCs in UniPhier family share the multi-platform kernel image,
so I think, this way is reasonable enough.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/