Re: [PATCH 2/2] dma: add Qualcomm Technologies HIDMA channel driver

From: Timur Tabi
Date: Fri Oct 30 2015 - 18:36:57 EST

On 10/30/2015 05:28 PM, Arnd Bergmann wrote:
> >Why ENODEV? Could you make this handle restarted system calls?
>This is the self test code. It gets called from probe. If there is a
>problem with the device or system configuration, I don't want to enable
>this device. I can certainly return a different error code though.
>What's a good code?
I see. probe() is not restartable, so it cannot be -ERESTARTSYS.

Maybe better use wait_event_timeout and not handle the signals then.
It will eventually time out if something goes wrong.

What about -EPROBE_DEFER? Isn't that "restartable"? Granted, it's only supposed to be used if the driver is dependent on another driver to probe, so I'm not sure it applies here. If the self-test fails, then it is possible that it could succeed later?

Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at