Re: [PATCH 4/4] locking: Introduce smp_cond_acquire()

From: David Howells
Date: Mon Nov 02 2015 - 15:37:02 EST


Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> > + smp_read_barrier_depends(); /* ctrl */ \
> > + smp_rmb(); /* ctrl + rmb := acquire */ \

Doesn't smp_rmb() imply an smp_read_barrier_depends() anyway? In
memory-barriers.txt, it says:

Read memory barriers imply data dependency barriers, and so can
substitute for them.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/