Re: [PATCHv2] rtc: Add a driver for Micro Crystal RV8803

From: Alexandre Belloni
Date: Tue Nov 03 2015 - 04:32:02 EST


On 03/11/2015 at 08:07:57 +0100, Julia Lawall wrote :
> It looks like it is worth a check.
>

Indeed, I missed that one.

Strangely, I didn't get that mail from the kbuild test robot (and the
list doesn't seem to have a copy either). Is that intended?

> julia
>
> On Tue, 3 Nov 2015, kbuild test robot wrote:
>
> > CC: kbuild-all@xxxxxx
> > In-Reply-To: <1446504512-9079-1-git-send-email-alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> > TO: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> > CC: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, rtc-linux@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> > CC: rtc-linux@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> >
> > Hi Alexandre,
> >
> > [auto build test WARNING on abelloni/rtc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> >
> > url: https://github.com/0day-ci/linux/commits/Alexandre-Belloni/rtc-Add-a-driver-for-Micro-Crystal-RV8803/20151103-065235
> > :::::: branch date: 51 minutes ago
> > :::::: commit date: 51 minutes ago
> >
> > >> drivers/rtc/rtc-rv8803.c:244:2-8: preceding lock on line 240
> >
> > git remote add linux-review https://github.com/0day-ci/linux
> > git remote update linux-review
> > git checkout f8c59e6bf4a130cb2f46cad981771dddecc406ff
> > vim +244 drivers/rtc/rtc-rv8803.c
> >
> > f8c59e6b Alexandre Belloni 2015-11-02 234 time64_t alarm_time = rtc_tm_to_time64(&alrm->time);
> > f8c59e6b Alexandre Belloni 2015-11-02 235
> > f8c59e6b Alexandre Belloni 2015-11-02 236 alarm_time += 60 - alrm->time.tm_sec;
> > f8c59e6b Alexandre Belloni 2015-11-02 237 rtc_time64_to_tm(alarm_time, &alrm->time);
> > f8c59e6b Alexandre Belloni 2015-11-02 238 }
> > f8c59e6b Alexandre Belloni 2015-11-02 239
> > f8c59e6b Alexandre Belloni 2015-11-02 @240 spin_lock_irqsave(&rv8803->flags_lock, irqflags);
> > f8c59e6b Alexandre Belloni 2015-11-02 241
> > f8c59e6b Alexandre Belloni 2015-11-02 242 ret = i2c_smbus_read_i2c_block_data(client, RV8803_FLAG, 2, ctrl);
> > f8c59e6b Alexandre Belloni 2015-11-02 243 if (ret != 2)
> > f8c59e6b Alexandre Belloni 2015-11-02 @244 return ret < 0 ? ret : -EIO;
> > f8c59e6b Alexandre Belloni 2015-11-02 245
> > f8c59e6b Alexandre Belloni 2015-11-02 246 alarmvals[0] = bin2bcd(alrm->time.tm_min);
> > f8c59e6b Alexandre Belloni 2015-11-02 247 alarmvals[1] = bin2bcd(alrm->time.tm_hour);
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
> >

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/