Re: [PATCH 3/5] perf tools: Parsing libbpf return value using err.h

[Arnaldo Carvalho de Melo]

Em Tue, Nov 03, 2015 at 12:17:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 03, 2015 at 10:44:44AM +0000, Wang Nan escreveu:
> > +++ b/tools/perf/tests/llvm.c
> > @@ -27,7 +27,7 @@ static int test__bpf_parsing(void *obj_buf, size_t obj_buf_sz)
> >  	struct bpf_object *obj;

> >  	obj = bpf_object__open_buffer(obj_buf, obj_buf_sz, NULL);
> > -	if (!obj)
> > +	if (IS_ERR(obj) || !obj)
 
> Well, since we've adopted IS_ERR() from the kernel, we better try to
> follow how it is used there, no?
 
> Since you move to use ERR_PTR(), you probably will never return NULL,
> right? So whay the (|| !obj) part?
 
> The kernel has an IS_ERR_OR_NULL() interface tho, trying to figure out
> when that would be appropriate...

I think you should change the error reporting convention _and_ the users
at the same time, i.e. please merge this patch with the next and use
plain:

	if (IS_ERR(obj))

Instead, ok?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/