Re: [PATCH] arcnet/com20020: add LEDS_CLASS dependency

From: David Miller
Date: Tue Nov 03 2015 - 11:34:44 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 03 Nov 2015 14:51:29 +0100

> The newly added led trigger support in the com20020-pci driver causes
> build errors when CONFIG_LEDS_CLASS is disabled:
>
> drivers/built-in.o: In function `com20020pci_probe':
> (.text+0x185dc4): undefined reference to `devm_led_classdev_register'
> (.text+0x185dd8): undefined reference to `devm_led_classdev_register'
>
> This adds a Kconfig dependency to prevent the invalid configurations.
> Other drivers appear to be split 50:50 between 'select' and 'depends on'
> for this symbol, I picked 'depends on' as I could not find a common
> policy and it generally causes fewer problems.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 8890624a4e8c ("arcnet: com20020-pci: add led trigger support")

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/