Re: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver

[Sinan Kaya]

On 11/9/2015 1:19 PM, Rob Herring wrote:
> On Sat, Nov 07, 2015 at 11:53:00PM -0500, Sinan Kaya wrote:
> > This patch adds support for hidma engine. The driver
> > consists of two logical blocks. The DMA engine interface
> > and the low-level interface. The hardware only supports
> > memcpy/memset and this driver only support memcpy
> > interface. HW and driver doesn't support slave interface.
> >
> > Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/dma/qcom_hidma.txt         |  18 +
> >   drivers/dma/qcom/Kconfig                           |   9 +
> >   drivers/dma/qcom/Makefile                          |   2 +
> >   drivers/dma/qcom/hidma.c                           | 743 ++++++++++++++++
> >   drivers/dma/qcom/hidma.h                           | 157 ++++
> >   drivers/dma/qcom/hidma_dbg.c                       | 225 +++++
> >   drivers/dma/qcom/hidma_ll.c                        | 944 +++++++++++++++++++++
> >   7 files changed, 2098 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/dma/qcom_hidma.txt
> >   create mode 100644 drivers/dma/qcom/hidma.c
> >   create mode 100644 drivers/dma/qcom/hidma.h
> >   create mode 100644 drivers/dma/qcom/hidma_dbg.c
> >   create mode 100644 drivers/dma/qcom/hidma_ll.c
> >
> > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma.txt b/Documentation/devicetree/bindings/dma/qcom_hidma.txt
> > new file mode 100644
> > index 0000000..c9fb2d44
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dma/qcom_hidma.txt
> > @@ -0,0 +1,18 @@
> > +Qualcomm Technologies HIDMA Channel driver
> > +
> > +Required properties:
> > +- compatible: must contain "qcom,hidma"
>
> This should be "qcom,hidma-1.0" to match the example and driver. I
> would drop "qcom,hidma" altogether.

I matched it.

> Rob

--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/