Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

From: Liviu Dudau
Date: Wed Nov 11 2015 - 12:57:24 EST


On Wed, Nov 11, 2015 at 05:51:52PM +0000, Russell King - ARM Linux wrote:
> On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote:
> > While going through the code testing I've noticed an unbalanced
> > .unbind missing drm_connector_unregister()
>
> That actually doesn't matter, as DRM automatically tears them down anyway,
> so this isn't an urgent change. However, it's good practice to do so.

It looks like it doesn't, or at least not if the error code is -EPROBE_DEFER.
On Juno, where the clocks are provided by SCPI and the load order is not
guaranteed, the first bind will fail with -EPROBE_DEFER but the sysfs entry
is not cleaned up, so on the next attempt the drm_connector_register() call
will fail.

Best regards,
Liviu

>
> --
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
Â\_(ã)_/Â
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/