Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

From: David Miller
Date: Thu Nov 12 2015 - 16:12:29 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Thu, 12 Nov 2015 22:03:40 +0100

> @@ -337,11 +337,11 @@ static int ipq806x_gmac_probe(struct platform_device *pdev)
> QSGMII_PHY_RX_SIGNAL_DETECT_EN |
> QSGMII_PHY_TX_DRIVER_EN |
> QSGMII_PHY_QSGMII_EN |
> - 0x4 << QSGMII_PHY_PHASE_LOOP_GAIN_OFFSET |
> - 0x3 << QSGMII_PHY_RX_DC_BIAS_OFFSET |
> - 0x1 << QSGMII_PHY_RX_INPUT_EQU_OFFSET |
> - 0x2 << QSGMII_PHY_CDR_PI_SLEW_OFFSET |
> - 0xC << QSGMII_PHY_TX_DRV_AMP_OFFSET);
> + 0x4ul << QSGMII_PHY_PHASE_LOOP_GAIN_OFFSET |
> + 0x3ul << QSGMII_PHY_RX_DC_BIAS_OFFSET |
> + 0x1ul << QSGMII_PHY_RX_INPUT_EQU_OFFSET |
> + 0x2ul << QSGMII_PHY_CDR_PI_SLEW_OFFSET |
> + 0xCul << QSGMII_PHY_TX_DRV_AMP_OFFSET);
> }
>

Indeed, this looks so much better.

Applied.

Thanks for looking more deeply into this!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/