Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

From: Felipe Ferreri Tonello
Date: Mon Nov 16 2015 - 06:41:27 EST


Hi Clemens,

On 13/11/15 08:11, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 10/11/15 18:43, Sergei Shtylyov wrote:
>>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>> struct usb_ep *in_ep, *out_ep;
>>>> struct snd_card *card;
>>>> struct snd_rawmidi *rmidi;
>>>> + u8 ms_id;
>>>
>>> Why 'ms_id' is not aligned with the above field names?
>>
>> It is actually aligned.
>
> It's not in the original mail, which contains tab characters.
>
>> Here is from my local git diff:
>>
>> @@ -75,6 +75,7 @@ struct f_midi {
>> struct usb_ep *in_ep, *out_ep;
>> struct snd_card *card;
>> struct snd_rawmidi *rmidi;
>> + u8 ms_id;
>
> Apparently, you're using four spaces per tab. Linux uses eight.

Yes. I'll fix that.

--
Felipe

Attachment: 0x92698E6A.asc
Description: application/pgp-keys