Re: crypto-ixp4xx: Deletion of a few unnecessary checks

From: SF Markus Elfring
Date: Wed Nov 18 2015 - 02:28:55 EST


>> Delete unnecessary checks before the function call "dma_pool_destroy"

It seems that you accepted this specific update suggestion, didn't you?
https://lkml.org/lkml/2015/11/17/391
https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1021951.html


>> Reduce assignment for a variable in init_ixp_crypto()
>> crypto-ixp4xx: Less function calls in init_ixp_crypto() after error detection
>
> You completely ignored my comments. Nack.

Will it be useful to clarify the proposed changes a bit more?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/