Re: [PATCH v11 6/8] Input: goodix - add support for ESD

From: Rob Herring
Date: Fri Nov 20 2015 - 10:45:13 EST


On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote:
> Add ESD (Electrostatic Discharge) protection mechanism.

[...]

> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
> driver gt9xx.c for Android (publicly available in Android kernel
> trees for various devices).
>
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
> For the binding: Acked-by: Rob Herring <robh@xxxxxxxxxx>

You should not have the "For the binding:" part here. It was just a note
so it was clear what part I looked at.

It is preferred to split DT bindings to separate patches for this
reason.

> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
> ---
> .../bindings/input/touchscreen/goodix.txt | 4 +
> drivers/input/touchscreen/goodix.c | 160 ++++++++++++++++++++-
> 2 files changed, 159 insertions(+), 5 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/