Re: [PATCH 31/37] perf callchain: Add count fields to struct callchain_node

From: Namhyung Kim
Date: Tue Nov 24 2015 - 00:15:57 EST


Hi Frederic,

On Mon, Nov 23, 2015 at 03:35:30PM +0100, Frederic Weisbecker wrote:
> Namhyung,
>
> On Thu, Nov 19, 2015 at 02:53:17PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Namhyung Kim <namhyung@xxxxxxxxxx>
> >
> > It's to track the count of occurrences of the callchains.
>
> Please explain why you do something like this in the changelog, even just a single
> line to tell which feature is going to use this and why.
>
> No need to resend just for that, it's just for future patches.

OK, I'll keep in mind that.

This patch is a preparation for supporting different callchain value
output style. Instead of current percent output, it could have period
or count with this change.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/