Re: [PATCH v2 1/1] stop_machine: Remove stop_cpus_lock and lg_double_lock/unlock()

From: Tejun Heo
Date: Tue Nov 24 2015 - 09:50:54 EST


Hello,

On Tue, Nov 24, 2015 at 10:51:56AM +0100, Peter Zijlstra wrote:
> On Mon, Nov 23, 2015 at 04:53:39PM -0500, Tejun Heo wrote:
> >
> > Isn't this a lot more subtler than the other direction? Unless
> > there's a clear performance advantage to removing stopper->lock, using
> > lglock for both stop_two and stop_machine seems like an
> > easier-to-follow approach to me.
>
> The idea is to kill lglock. There's only two users, this and fs/locks.c
> for which I have patches -- which are being benchmarked 'now-ish' :-)

Ah, I see. Please disregard my comment. The patch looks good to me.
Please feel free to add

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/