Re: [PATCH] thermal: rcar: add .set_trip_temp support

From: Eduardo Valentin
Date: Mon Nov 30 2015 - 13:51:11 EST


On Wed, Nov 25, 2015 at 05:42:27AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> You can set trip temp if your kernel has CONFIG_THERMAL_WRITABLE_TRIPS
>
> echo $temp > /sys/class/thermal/thermal_zone0/trip_point_0_temp
>
> -45000 < $temp < 125000 is supported
> Default is 90000
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> ---
> This patch is v2 of "[PATCH] thermal: rcar: enable to set tripN-temp via DT"
> I think it will be full-DT feature if it uses of-thermal, but this driver is used
> from non-DT SoC too. We would like to keep non-DT support.
> And we would like to do is only exchange trip temp.
> .set_trip_temp is very enouth for it at this point.
> But, it can use of-thermal feature in the future.

Kuninori,


According to discussion on your first version [1], this patch is not needed
anymore, right?

If you want to add the support for writable trip points, please, add the
support to of-thermal, as this driver supports only DT booting boards.


[1] - https://lkml.org/lkml/2015/11/25/888
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/