Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)

From: Mike Galbraith
Date: Wed Dec 02 2015 - 01:21:35 EST


On Tue, 2015-12-01 at 11:49 -0500, Tejun Heo wrote:
> On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> >
> > Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,
> > where they belong. This makes it possible to attach PF_NO_SETAFFINITY
> > tasks to Intel CAT cgroup.
> >
> > Reported-by: Luiz Capitulino <lcapitulino@xxxxxxxxxx>
> > Signed-off-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> > Reviewed-by: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
> >
> > v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> > checks"
>
> This wasn't just for cpuset. It's for all controllers.

Hm, indeed. Workers landing in a throttled cfs rq wouldn't be as
painful as an rt worker being born in an rq with no rt_runtime, but
could sting. Workers stuffed into the freezer would sting mightily.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/