Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter

[Jason Gunthorpe]

On Wed, Dec 02, 2015 at 01:34:38PM +0100, Wilck, Martin wrote:
> On Di, 2015-12-01 at 11:58 -0700, Jason Gunthorpe wrote:
> 
> > Martin, this should fix the double loading you noticed, please confirm.  There
> > is a possibility the force path needs a bit more code to be compatible with
> > devm_ioremap_resource, I'm not sure, hoping not.
> 
> Nope, this one oopses in the ACPI probing path.

This fixes this oops:

        chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res);
-       if (!chip->vendor.iobase)
-               return -EIO;
+       if (IS_ERR(chip->vendor.iobase))
+               return PTR_ERR(chip->vendor.iobase);


And I see that the ACPI stuff needs other work :(

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/