Re: [PATCH 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists

From: Jisheng Zhang
Date: Fri Dec 04 2015 - 09:19:26 EST


cc linux-usb@xxxxxxxxxxxxxxx

On Fri, 4 Dec 2015 22:10:48 +0800
Jisheng Zhang wrote:

> Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the
> usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the
> suspend/resume path. This patch fixes this issue by adding missing
> usb_phy related calls.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-plat.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index a8c465a..cd49ae5 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -244,6 +244,7 @@ static int xhci_plat_suspend(struct device *dev)
> if (ret)
> return ret;
>
> + usb_phy_shutdown(xhci->shared_hcd->usb_phy);
> clk_disable_unprepare(xhci->clk);
>
> return ret;
> @@ -259,6 +260,10 @@ static int xhci_plat_resume(struct device *dev)
> if (ret)
> return ret;
>
> + ret = usb_phy_init(xhci->shared_hcd->usb_phy);
> + if (ret)
> + return ret;
> +
> return xhci_resume(xhci, 0);
> }
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/