Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32_PFN

From: Ingo Molnar
Date: Fri Dec 04 2015 - 09:34:26 EST



* Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:

> On 04/12/2015 13:33, Igor Mammedov wrote:
> > That doesn't pass strict type check:
> >
> > include/linux/kernel.h:730:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > (void) (&_max1 == &_max2); \
> > ^
> > arch/x86/mm/srat.c:206:21: note: in expansion of macro âmaxâ
> > max_possible_pfn = max(max_possible_pfn, PFN_UP(end - 1));
> >
> > I can change max_possible_pfn to u64 to match PFN_UP(end - 1) type.
>
> Sounds like a good idea anyway.

Yeah, agreed.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/