Re: [PATCH] iio: st_accel_core: Remove unneeded define

From: Jonathan Cameron
Date: Sat Dec 05 2015 - 12:29:15 EST


On 03/12/15 23:54, Robert Kmiec wrote:
> Definition of ST_SENSORS_WAI_ADDRESS was introduced within a very
> first commit of this driver, but it was never used.
> This address is already defined as ST_SENSORS_DEFAULT_WAI_ADDRESS
> in include/linux/iio/common/st_sensors.h
>
> To avoid duplication of the same constant in two different places
> called almost exactly the same, the one which was never used
> should be removed.
>
> Signed-off-by: Robert Kmiec <robert.r.kmiec@xxxxxxxxx>
Fair enough.

Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/iio/common/st_sensors/st_sensors_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index 25258e2..8447c31 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -18,9 +18,6 @@
> #include <asm/unaligned.h>
> #include <linux/iio/common/st_sensors.h>
>
> -
> -#define ST_SENSORS_WAI_ADDRESS 0x0f
> -
> static inline u32 st_sensors_get_unaligned_le24(const u8 *p)
> {
> return (s32)((p[0] | p[1] << 8 | p[2] << 16) << 8) >> 8;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/