Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

[Joe Perches]

On Sun, 2015-12-06 at 22:29 -0500, David Miller wrote:
> From: yankejian <yankejian@xxxxxxxxxx>
> Date: Sat, 5 Dec 2015 15:32:29 +0800
> 
> > +#if (PAGE_SIZE < 8192)
> > +     if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) {
> > +             truesize = hnae_buf_size(ring);
> > +     } else {
> > +             truesize = ALIGN(size, L1_CACHE_BYTES);
> > +             last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
> > +     }
> > +
> > +#else
> > +             truesize = ALIGN(size, L1_CACHE_BYTES);
> > +             last_offset = hnae_page_size(ring) - hnae_buf_size(ring);
> > +#endif
> 
> This is not indented properly, and it looks terrible.

And it makes one curious as to why last_offset isn't set
in the first block.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/