Re: [PATCH v5] pwm-backlight: Avoid backlight flicker when probed from DT

From: Lee Jones
Date: Mon Dec 07 2015 - 04:35:20 EST


On Mon, 07 Dec 2015, Daniel Kurtz wrote:

> Hi Lee,
>
> On Wed, Nov 25, 2015 at 12:26 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > On Wed, 18 Nov 2015, Philipp Zabel wrote:
> >
> >> If the driver is probed from the device tree, and there is a phandle
> >> property set on it, and the enable GPIO is already configured as output,
> >> and the backlight is currently disabled, keep it disabled.
> >> If all these conditions are met, assume there will be some other driver
> >> that can enable the backlight at the appropriate time.
> >>
> >> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> >> Reviewed-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> >> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
> >> ---
> >> - Rebased onto v4.4-rc1
> >> - Added Heiko's Tested-by
> >> ---
> >> drivers/video/backlight/pwm_bl.c | 23 ++++++++++++++++++++++-
> >> 1 file changed, 22 insertions(+), 1 deletion(-)
> >
> > Applied, thanks.
>
> Hmm, where was this applied? I do not see it in:
> * v4.4-rc4
> * linux-next next-20151203 (dcccebc - Add linux-next specific files
> for 20151203)
>
> Nor do I see it in any branch in:
> * git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight
> Is this the right git?

Yes, that's right. When I say "applied", it means I applied it to my
local repository. I am careful not to allude to the patch being
"pushed". There is no guarantee when this will happen, since it
completly depends how busy the subsystem is. For Backlight, as the
churn is low, the impetus for pushing is pretty low.

It has been "pushed" now though.

> By the way this repository has a git tag called "HEAD", which is a bit
> annoying since every time I "git remote update" from here, git gets
> confused until I manually delete it (git tag -d HEAD).

Thanks for letting me know. I have now removed this tag.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/