Re: [PATCH] Documentation: email-clients.txt

From: Austin S Hemmelgarn
Date: Mon Dec 07 2015 - 13:17:34 EST


On 2015-12-06 15:52, Randy Dunlap wrote:
On 12/06/15 07:30, Jonathan Corbet wrote:
On Sun, 6 Dec 2015 01:09:39 -0500
Sanidhya Solanki <jpage.lkml@xxxxxxxxx> wrote:

Patch included below. As an aside, thank you for the excellent work on
the books and other documentation.

Thanks for the nice comments. Future praise, however, should go below the
"---" marker so I don't have to edit it out of the changelogs :)

Documentation: email-clients.txt

The information for Claws Mail, Evolution and Thunderbird was out of
date. It has been updated with new instructions and warnings.

So I feel like I'm missing some sort of intentional irony, but I do have
to point out that this patch has been corrupted by your mailer and cannot
be applied. The usual advice here applies: try sending the email to
yourself and applying the result.

diff --git a/Documentation/email-clients.txt
b/Documentation/email-clients.txt index 2d485de..8819c90 100644
--- a/Documentation/email-clients.txt
+++ b/Documentation/email-clients.txt
@@ -79,17 +79,27 @@ to insert into the message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Claws Mail (GUI)

-Works. Some people use this successfully for patches.
+Tested and Works as of December 2015. Some people use this successfully
+for patches.

Not sure we need datestamps like this here. In any case, a few kernel
developers are known to use claws - myself included. We test it every day :)

To insert a patch use Message->Insert File (CTRL+i) or an external
editor.
If the inserted patch has to be edited in the Claws composition window
"Auto wrapping" in Configuration->Preferences->Compose->Wrapping
should be -disabled.
+disabled. Also, under the heading "View", sub-heading "Character
Encoding" +, choose "Unicode (UTF - 8)"
+
+Do remember that if you insert or type something in the main text area,
+and decide to delete it, you will need to reset the formatting by
opening +a new window for the change you want to make. Re-using the
window in which +you deleted the text will lead to the new message
being mangled.

...and this makes no sense to me. I've never seen any such behavior in
claws?

Evolution (GUI)

+As of December 2015, the composing & inserting method described below
+does not work.

Could it really be that nobody is using evolution? Much nicer here would
be to describe how it fails to work, and, ideally, come up with a fix.

Some people use this successfully for patches.

When composing mail select: Preformat
@@ -244,8 +254,9 @@ Sylpheed (GUI)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thunderbird (GUI)

-Thunderbird is an Outlook clone that likes to mangle text, but there
are ways -to coerce it into behaving.
+Thunderbird is an Outlook clone that likes to mangle text, but there
are +ways to coerce it into behaving. In December 2015, the internal
editor +options do not appear to work.

Again, what's the problem here? I suspect there are people using
Thunderbird out there, how are they doing it if the documented approach
doesn't work?

I use thunderbird with an external editor plugin, so I just insert patches with
the external editor.

It may be worth noting that you can get a plugin that lets you just toggle word-wrap with the internal editor (rather un-inventively called 'Toggle Word Wrap'), and that _seems_ to work most of the time. The down side to this of course is that it toggles for the whole message, and not just parts of it.


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature