Re: [RFC PATCH] mm: memcontrol: reign in CONFIG space madness
From: Johannes Weiner
Date: Thu Dec 10 2015 - 10:08:09 EST
On Thu, Dec 10, 2015 at 02:40:31PM +0100, Michal Hocko wrote:
> On Wed 09-12-15 15:30:04, Johannes Weiner wrote:
> > Hey guys,
> > there has been quite a bit of trouble that stems from dividing our
> > CONFIG space and having to provide real code and dummy functions
> > correctly in all possible combinations. This is amplified by having
> > the legacy mode and the cgroup2 mode in the same file sharing code.
> > The socket memory and kmem accounting series is a nightmare in that
> > respect, and I'm still in the process of sorting it out. But no matter
> > what the outcome there is going to be, what do you think about getting
> > rid of the CONFIG_MEMCG[_LEGACY]_KMEM and CONFIG_INET stuff?
> The code size difference after your recent patches is indeed not that
> large but that is only because huge part of the kmem code is enabled by
> default now. I have raised this in the reply to the respective patch.
> This is ~8K of the code 1K for data. I do understand your reasoning
> about the complications but this is quite a lot of code. CONFIG_INET
> ifdefs are probably pointless - they do not add really much and most
> configs will have it by default. The core for KMEM seems to be a
> different thing to me. Maybe we can reorganize the code to make the
> maintenance easier and still allow to enable KMEM accounting separately
> for kernel size savy users?
Look, if kernel size savvy users care THAT much about TWO pages then
they must absolutely LOVE me for having eliminated page_cgroup and
saving them THOUSANDS of pages, and deleted hundreds of lines of code
and static data in memcontrol.c ever since I started working on it.
Yet this has been the only point you have been bringing up this entire
time: the cost I'm putting on users with all this in both memory and
cpu cycles. When I have just made all hotpaths and accounting in memcg
completely lockless. And when cgroup2 is going to be a FRACTION of the
original memcg code, data size, and runtime cost, even INCLUDING the
entirety of the kmem accounting.
There is no perspective to your criticism.
So let's just say I'm going to cash some of that credit I built up in
order to get to v2 as fast as possible, without having to spend days
engineering a solution to save two damn pages in legacy code, okay?
And if you DO care so much about cost for legacy users beyond this, I
think it's time for you to put your money where your mouth is and
start sending patches that save those users memory and cpu cycles,
instead of constantly demanding this from people who work on making
this whole thing much leaner, faster, and cleaner for EVERYBODY.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/