Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma

From: Alan Stern
Date: Thu Dec 10 2015 - 10:57:29 EST


On Thu, 10 Dec 2015, Peter Senna Tschudin wrote:

> > /* next async queue entry, or pointer to interrupt/periodic QH */
> > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH))
> > +#define QH_NEXT(ehci, dma) \
> > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH))
>
> For the maintainers: Is having two lines here better than having a line with 83 chars?

Two lines is better. This patch is fine and so are the other 7 -- I
never received 9/9v2 (the original 9/9 was okay).

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/