Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma

From: Geyslan G. Bem
Date: Thu Dec 10 2015 - 11:02:21 EST


2015-12-10 12:57 GMT-03:00 Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>:
> On Thu, 10 Dec 2015, Peter Senna Tschudin wrote:
>
>> > /* next async queue entry, or pointer to interrupt/periodic QH */
>> > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH))
>> > +#define QH_NEXT(ehci, dma) \
>> > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH))
>>
>> For the maintainers: Is having two lines here better than having a line with 83 chars?
>
> Two lines is better. This patch is fine and so are the other 7 -- I
> never received 9/9v2 (the original 9/9 was okay).
Alan,

The 9 is v1 only, since it mentions the tool (coccinelle) correctly.

Tks.

>
> Alan Stern
>



--
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/